Remove explicit transactions #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit transactions are disabled for a while. We have bunch of issues related to connection affinity. They work only with sidecar setup. Even then, they are generating quiet a few corner cases with schema management requests. We have decided to go with MongoDB compatible transactions based on sessions. Removing this code to make way for them.
apkar
force-pushed
the
remove-explicit-tr
branch
from
550db70
to
f51d00f
Compare
dongxinEric
reviewed
Apr 10, 2019
| exceptionOne = e | ||
| try: | ||
| func1(*args2, **kwargs2) | ||
| func2(*args2, **kwargs2) |
There was a problem hiding this comment.
It was a luck/unfortunate that when using transactional_shim, func1 and func2 are always the same LOL. My bad anyways.
dongxinEric
reviewed
Apr 10, 2019
| @@ -495,7 +495,7 @@ def insert_one(self, dict): | |||
| def insert_many(self, list): | |||
| self.insert(list) | |||
|
|
|||
| def find(self, query, fields=None): | |||
| def find(self, query, fields=None, batch_size=None): | |||
There was a problem hiding this comment.
What's this batch_size used for?
There was a problem hiding this comment.
batch_size from driver converts to numberToReturn in OP_QUERY. This is kind of page size for large queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit transactions are disabled for a while. We have a bunch of issues
related to connection affinity. They work only with sidecar setup. Even
then, they are generating quite a few corner cases with schema
management requests.
We have decided to go with MongoDB compatible transactions based on
sessions. Removing this code to make way for them.