-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/web #23
Conversation
simple backend layout work more styling header styling more styling initial work on diffs working on styling and comparisons more ui wip ui command introduced introducing monaco editor basic editing works menu added styling updates more styling more styling opening browser window upon ui startup basic run triggering wip uvicorn added styling and other fixes window title ui fixes, ui command refactored refactor wip refactor wip refactor wip refactor, tests, deps update refactor, updates, styling more styling updates fixes and styling tokens per second, styling, bugfixes wip monaco editor used to show diffs quick fixes error experience
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also there's single test that's failing:
______________________________________________________________________________________________________________________________________ TestPromptConfigLoader.test_basics _______________________________________________________________________________________________________________________________________
self = <test_run_collection.TestPromptConfigLoader object at 0x7fced98a4310>
def test_basics(self):
prompt_path = os.path.join(
THIS_FILE_DIR, "..", "fixtures", "run_collection", "basic.yaml"
)
assert os.path.exists(prompt_path)
assert os.access(prompt_path, os.R_OK)
loader = PromptConfigLoader()
prompt_config = loader.load_from_path(prompt_path)
assert prompt_config
collection = PromptRunCollection(prompt_config)
assert collection
assert collection.is_empty() == False
assert collection.has_done_runs() == True
> assert len(collection.runs) == 3
E assert 1 == 3
E + where 1 = len([<prr.runner.saved_prompt_run.SavedPromptRun object at 0x7fced973f730>])
E + where [<prr.runner.saved_prompt_run.SavedPromptRun object at 0x7fced973f730>] = <prr.runner.run_collection.PromptRunCollection object at 0x7fced98a7310>.runs
test/runner/test_run_collection.py:33: AssertionError
@@ -17,7 +17,7 @@ pyyaml = "^6.0" | |||
google-cloud-aiplatform = "^1.25.0" | |||
huggingface-hub = "^0.14.1" | |||
text-generation = "^0.5.2" | |||
elevenlabs = "^0.2.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to bring it back, it crashes without it
prr/__main__.py
Outdated
command = UIPromptCommand(parsed_args) | ||
command.start() | ||
|
||
if not check_if_prompt_exists(parsed_args["prompt_path"]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there's no file provided as an argument it just crashes
ideally, we want to raise an error and show available flags
No description provided.