Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for cosmetic objects #29

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Add tests for cosmetic objects #29

merged 7 commits into from
Oct 16, 2024

Conversation

Luc1412
Copy link
Member

@Luc1412 Luc1412 commented Oct 14, 2024

Summary

This pull request add tests for all cosmetic objects.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Luc1412 Luc1412 self-assigned this Oct 14, 2024
Copy link
Collaborator

@trevorflahardy trevorflahardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

tests/test_async_methods.py Outdated Show resolved Hide resolved
tests/test_async_methods.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@trevorflahardy trevorflahardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! Good work, this looks good to go 👍 Merge whenever you're ready

@Luc1412 Luc1412 merged commit b5ebfa1 into master Oct 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants