Fix usage for decorated class properties #17326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the following `tsconfig.json`:
```json
{
"compilerOptions": {
"emitDecoratorMetadata": true,
"experimentalDecorators": true
}
}
```
The following will currently causes an import error:
```ts
import { IconName } from '@fortawesome/fontawesome-common-types';
class MyClass {
@MyDecorator
icon: IconName;
}
```
This is because in some situations TypeScript doesn’t know that `IconName` is a
only exists as a type. It will generate an import, which can’t be resolved.
Simply adding an empty JavaScript file, will make the environment able to import
the package, even though the import value of `IconName` will be `undefined`.
|
Hi! Thanks for being part of the Font Awesome Community and thanks for this PR. @robmadole @mlwilkerson could you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following
tsconfig.json:{ "compilerOptions": { "emitDecoratorMetadata": true, "experimentalDecorators": true } }The following will currently causes an import error:
This is because in some situations TypeScript doesn’t know that
IconNameis aonly exists as a type. It will generate an import, which can’t be resolved.
Simply adding an empty JavaScript file, will make the environment able to import
the package, even though the import value of
IconNamewill beundefined.I understand that:
I understand that it will not be merged and I will not be listed as a contributor on this project.