Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Update victory #104

Merged
merged 6 commits into from
Jun 16, 2017
Merged

Update victory #104

merged 6 commits into from
Jun 16, 2017

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Jun 14, 2017

cc/ @chrisbolin this PR updates Victory to 0.21.0 and adds support for polar charts.

Caveats:
I couldn't figure out how to work around https://github.com/FormidableLabs/victory-native/issues/103, so I've temporarily disabled text rotations

Spurious test failure for VictoryLabel Updated react-native-svg-mock to include TSpan mock

@chrisbolin
Copy link
Contributor

I'm getting Warning: Each child in an array or iterator should have a unique "key" prop. in the demo. Trace:
ExceptionsManager.js:71 Warning: Each child in an array or iterator should have a unique "key" prop.

Check the render method of `_class`. See https://fb.me/react-warning-keys for more information.
    in Path (at area.js:20)
    in _class (at victory-area.js:13)
    in RNSVGGroup (at G.js:20)
    in G (at victory-clip-container.js:17)
    in RNSVGGroup (at G.js:20)
    in G (at victory-clip-container.js:15)
    in VictoryClipContainer (at victory-area.js:16)
    in VictoryArea (at demo.js:408)
    in RNSVGGroup (at G.js:20)
    in G (at victory-stack.js:12)
    in VictoryStack (at demo.js:407)
    in RNSVGSvgView (at Svg.js:80)
    in Svg (at victory-container.js:82)
    in RCTView (at View.js:128)
    in View (at victory-container.js:81)
    in VictoryContainer (at victory-chart.js:13)
    in VictoryChart (at demo.js:406)
    in RCTScrollContentView (at ScrollView.js:649)
    in RCTScrollView (at ScrollView.js:732)
    in ScrollView (at demo.js:136)
    in Demo (at renderApplication.js:35)
    in RCTView (at View.js:128)
    in View (at AppContainer.js:93)
    in RCTView (at View.js:128)
    in View (at AppContainer.js:92)
    in AppContainer (at renderApplication.js:34)

I don't think that's demo-specific?

@chrisbolin
Copy link
Contributor

but that could be completely unrelated to this PR

@boygirl
Copy link
Contributor Author

boygirl commented Jun 16, 2017

cool. Travis isn't picking up my latest published versions of react-native-svg-mock or victory-chart

both are showing up in the registry...
https://www.npmjs.com/package/victory-chart
https://www.npmjs.com/package/react-native-svg-mock

@boygirl
Copy link
Contributor Author

boygirl commented Jun 16, 2017

Yay! It caught up!

@boygirl
Copy link
Contributor Author

boygirl commented Jun 16, 2017

Working for me too now. Merging :)

@boygirl boygirl merged commit 9f18979 into master Jun 16, 2017
@boygirl boygirl deleted the update-victory branch June 16, 2017 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants