Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize App UI and demo charts #71

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Finalize App UI and demo charts #71

merged 4 commits into from
Aug 29, 2023

Conversation

carloskelly13
Copy link
Contributor

IMG_4504
IMG_4505
IMG_4506
IMG_4507
IMG_4508
IMG_4509

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview Aug 29, 2023 1:31pm

gksander
gksander approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments.

example/app/line-chart.tsx Outdated Show resolved Hide resolved
example/app/stock-price.tsx Outdated Show resolved Hide resolved
@carloskelly13 carloskelly13 merged commit 92a327a into main Aug 29, 2023
1 check passed
@carloskelly13 carloskelly13 deleted the task/demo-app-final-ui branch August 29, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gksander gksander gksander approved these changes

@keithluchtel keithluchtel Awaiting requested review from keithluchtel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carloskelly13 @gksander