Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frame line width configurable per side #397

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

keithluchtel
Copy link
Member

@keithluchtel keithluchtel commented Oct 15, 2024

Updates the lineWidth prop for frame to allow for configuring the width per side.

Description

Fixes #394

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Updates the `lineWidth` prop for `frame` to allow for configuring the width per side.
Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 9e3f8c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:33pm

Copy link
Contributor

@zibs zibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 😎

lib/src/cartesian/components/Frame.tsx Outdated Show resolved Hide resolved
@zibs
Copy link
Contributor

zibs commented Oct 15, 2024

merge away!

@keithluchtel keithluchtel merged commit 641e82c into main Oct 15, 2024
3 checks passed
@keithluchtel keithluchtel deleted the feat/frame-side-config branch October 15, 2024 21:48
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the frame setting for a particular side of the axis.
2 participants