Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pie size prop #392

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat: add pie size prop #392

merged 2 commits into from
Oct 15, 2024

Conversation

zibs
Copy link
Contributor

@zibs zibs commented Oct 8, 2024

Description

Adds pie size prop so that it is customizable and not just the width/height of the canvas itself. This is partially useful for being able to position the labels beyond the pie itself.

Fixes #390

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

This lets users adjust the size of the pie in case they want to position the labels outside the pie.
@zibs zibs requested a review from carbonrobot October 8, 2024 21:32
Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 2c35bbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 3:20pm

@zibs zibs merged commit 0225751 into main Oct 15, 2024
3 checks passed
@zibs zibs deleted the feat/add-pie-size-prop branch October 15, 2024 15:14
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The size of the Pie should be configurable, i.e. less than the canvas size to display label outside of the pie
2 participants