Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit count.index for Terraform 0.12 #58

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Use explicit count.index for Terraform 0.12 #58

merged 3 commits into from
Sep 18, 2019

Conversation

tptee
Copy link
Contributor

@tptee tptee commented Sep 17, 2019

Terraform 0.12 is more strict with count–if count was 1 in 0.11, it didn't make you use the count.index + splat syntax.

@tptee tptee requested a review from ryan-roemer September 17, 2019 22:37
ryan-roemer
ryan-roemer approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tptee
Copy link
Contributor Author

tptee commented Sep 18, 2019

Going to merge with the revert to splat syntax since the explicit names break the dependencies between groups and their policy attachments!

@tptee tptee merged commit ebb1d7c into master Sep 18, 2019
@tptee tptee deleted the bug/0.12-count branch September 18, 2019 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-roemer ryan-roemer ryan-roemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tptee @ryan-roemer