Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live preview url to docs lander #860

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Conversation

kale-stew
Copy link
Contributor

Description

We weren't using some keys in _content so I got rid of them (unless someone objects) - I don't see us using them in the near future anyway?

I think it would be handy for the live preview to click through to the real live preview.

Type of Change

  • New feature (non-breaking change which adds functionality)

@kale-stew
Copy link
Contributor Author

CI fails over the surge login, not really sure why 🤔

@ryan-roemer
Copy link
Member

Surge failure is:

[deploy/surge] Uploading files to formidable-com-spectacle-staging-860.surge.sh
   Invalid token

which doesn't seem quite right (e.g., nothing in this PR would affect it).

Rebuilding just the Travis doc task to see if we get a successful deploy.

@ryan-roemer
Copy link
Member

Surge token locally appears invalid too. I've update 1password with the current token from surge token after a login and updated here in this PR in encrypted travis secrets. 🤞

@ryan-roemer
Copy link
Member

After new token, deploy went through. Weird:

$ node scripts/deploy/surge.js
[deploy/surge] Uploading files to formidable-com-spectacle-staging-860.surge.sh
   Running as [secure] (Student)
        project: /home/travis/build/FormidableLabs/spectacle/docs/dist
         domain: formidable-com-spectacle-staging-860.surge.sh
             IP: 45.55.110.124
   Success! - Published to formidable-com-spectacle-staging-860.surge.sh

@kale-stew kale-stew merged commit 58e404a into master Mar 10, 2020
@kale-stew kale-stew deleted the task/docs/add-demo-url branch March 10, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants