Refactor/remove unused dispatcher code and implement useCallback #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can derive this from workInProgressHook.queue and in useReducer we keep an update queue anyway.
Previously useCallback was a noop, however this leads to confusing situations where people rely on useCallback being a stable reference.
JoviDeCroock
approved these changes
Feb 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 99.54% 99.53% -0.02%
==========================================
Files 9 9
Lines 437 427 -10
Branches 70 68 -2
==========================================
- Hits 435 425 -10
Misses 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.