Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix metro for example app for iOS #1005

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix metro for example app for iOS #1005

merged 1 commit into from
Jul 24, 2024

Conversation

zibs
Copy link
Contributor

@zibs zibs commented Jul 24, 2024

Description

Fixes metro with monorepo: https://docs.expo.dev/guides/monorepos/#modify-the-metro-config

I missed with #988 when verifying it worked on iOS that I hadn't cleared my node modules before running, so all the deps worked fine. But if someone were to clone the repo from fresh and try, they'd run into metro errors.

Steps to verify

Clone the repo and follow the install and running steps and see the app work.

@zibs zibs requested a review from carbonrobot July 24, 2024 16:48
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-app-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 4:48pm

Copy link

changeset-bot bot commented Jul 24, 2024

⚠️ No Changeset found

Latest commit: 6370cc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carbonrobot carbonrobot merged commit 8d2f1e7 into main Jul 24, 2024
3 checks passed
@carbonrobot carbonrobot deleted the fix/example-app-ios branch July 24, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants