This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
When hovering, remove :hover from the previous hovered component #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The one thing this doesn't cover is nested elements, where it is certainly possible to have :hover on multiple elements at once. See example: https://jsbin.com/lenave/1/edit?js,console,output |
|
Good point! |
|
Closing this PR for now, feel free to reopen if you can think of a better approach. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
I haven't written tests around this, as I'm not sure you will accept it due to the (admittedly ugly!) global state.
However, this has solved my problem, when running it locally.
If this is accepted in theory, I'll make it ready for pulling!