This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Fix media query ordering #1015
Closed
Fix media query ordering #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identical media queries with identical rulesets across different components were being deduped which broke user defined media query ordering
rawrmonstar
commented
Dec 20, 2018
| @@ -150,7 +151,7 @@ rules: | |||
| no-undefined: 0 # disallow use of undefined variable | |||
| no-unused-vars: 2 # disallow declaration of variables that are not used in | |||
| # the code | |||
| no-use-before-define: 2 # disallow use of variables before they are defined | |||
| no-use-before-define: 1 # disallow use of variables before they are defined | |||
There was a problem hiding this comment.
I think adding the es6 env made it so eslint started checking this rule... there are 2 instances in the code base from before this PR that don't follow this rule. I could go and fix them by moving the declarations to the top of the file, but they are unrelated to this PR. Their uses are valid though.
|
Closing this in favor of the old #635. My solution was basically a less informed version of the work done in that ongoing PR. I didn't know that that PR existed before. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #975
Identical media queries with identical rulesets across different components were being deduped which
broke user-defined media query ordering.