Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Okaidia theme #103

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Add Okaidia theme #103

merged 2 commits into from
Feb 17, 2021

Conversation

yakkomajuri
Copy link
Contributor

@yakkomajuri
Copy link
Contributor Author

yakkomajuri commented Feb 9, 2021

Not sure who to tag here - @JonShort ? @kitten ?

@JonShort
Copy link
Contributor

JonShort commented Feb 9, 2021

👋 I think Phil is the maintainer of this library (I just had something merged last 😆)

Either way, I shimmed your work into a sandbox and it looks good 👍 I'm not really familar with the theme, but looking at official okaidia example it looks like there might be some differences, mostly in the non-JS syntax highlighting

(Again, I'm not familar with the theme so might be missing something 😁 - if so, feel free to ignore this)


image


Link to sandbox - https://codesandbox.io/s/prism-react-renderer-okaidia-jnrwx
Link to official example - https://prismjs.com/#examples (ensure 'okaidia' is selected on right column radio buttons)

@yakkomajuri
Copy link
Contributor Author

By no means! Thanks for the feedback - I put this together quickly for a personal need, but tagged the original theme author to get feedback. Will update accordingly!

@yakkomajuri
Copy link
Contributor Author

Some significant updates here, but I don't believe this can be perfect because it seems the two libraries have some differences when parsing the languages and adding the class names to the code.

HTML tags for example are rendered as plain in the sandbox, and tag in the official Prism website.

@yakkomajuri
Copy link
Contributor Author

Could be wrong though - have been quite busy so not too much time to look into everything

@kitten kitten merged commit 8caf552 into FormidableLabs:master Feb 17, 2021
@manuelpuyol manuelpuyol mentioned this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants