chore:Nx 20 #477
Merged
chore:Nx 20 #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 33a35a7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
ryanbas21
force-pushed
the
nx-20
branch
2 times, most recently
from
ba62033
to
e463b23
Compare
chore: fix-side-effects add side effects array to the package.json for sdk&protect.
cerebrl
reviewed
Oct 16, 2024
e2e/mock-api/src/app/routes.auth.js
Outdated
| @@ -539,7 +539,7 @@ export default function (app) { | |||
| const domain = req.url.includes('localhost') ? 'localhost' : 'example.com'; | |||
|
|
|||
| res.clearCookie('redirected'); | |||
| res.cookie('iPlanetDirectoryPro', 'abcd1234', { domain, sameSite: 'none', secure: true }); | |||
| res.cookie('iPlanetDirectoryPro', 'abcd1234'); | |||
There was a problem hiding this comment.
Let's only remove the secure: true from the props. The rest are good to stay.
cerebrl
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Please link jira ticket here
Description
Type of Change
Please Delete options that are not relevant
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Definition of Done
Check all that apply
Documentation