-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:Nx 20 #477
chore:Nx 20 #477
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 33a35a7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
ba62033
to
e463b23
Compare
chore: fix-side-effects add side effects array to the package.json for sdk&protect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good generally. If this changes how the Token Vault, especially the Interceptor, is built. Let's make sure we really do cross-browser testing.
I did leave one small change request.
e2e/mock-api/src/app/routes.auth.js
Outdated
@@ -539,7 +539,7 @@ export default function (app) { | |||
const domain = req.url.includes('localhost') ? 'localhost' : 'example.com'; | |||
|
|||
res.clearCookie('redirected'); | |||
res.cookie('iPlanetDirectoryPro', 'abcd1234', { domain, sameSite: 'none', secure: true }); | |||
res.cookie('iPlanetDirectoryPro', 'abcd1234'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's only remove the secure: true
from the props. The rest are good to stay.
JIRA Ticket
Please link jira ticket here
Description
Type of Change
Please Delete options that are not relevant
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Definition of Done
Check all that apply
Documentation