Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(token-vault): add readme #375

Merged
merged 1 commit into from
Jul 21, 2023
Merged

docs(token-vault): add readme #375

merged 1 commit into from
Jul 21, 2023

Conversation

cerebrl
Copy link
Contributor

@cerebrl cerebrl commented Jul 21, 2023 •
edited
Loading

JIRA Ticket

SDKS-2550

Description

Adding a README.md to the Token Vault project.

Type of Change

  • Docs

How Has This Been Tested?

No testing needed, but has been reviewed by multiple people.

Definition of Done

Check all that apply

  • Acceptance criteria is met.
  • All tasks listed in the user story have been completed.
  • Coded to standards.
  • Code peer-reviewed.
  • Ensure backward compatibility (special attention).
  • API reference docs is updated.
  • Unit tests are written.
  • Integration tests are written.
  • e2e tests are written.
  • CI build passing on the feature branch.
  • Functional spec is written/updated
  • contains example code snippets.
  • Change log updated.
  • Documentation story is created and tracked.
  • UI is completed or ticket is created.
  • Demo to PO and team.
  • Tech debts and remaining tasks are tracked in separated ticket(s).

Documentation

  • Acceptance criteria met
  • Spell-check run
  • Peer reviewed
  • Proofread

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a1a8d11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cerebrl cerebrl temporarily deployed to Preview July 21, 2023 20:26 — with GitHub Actions Inactive
@github-actions github-actions bot added the docs label Jul 21, 2023
ryanbas21
ryanbas21 reviewed Jul 21, 2023
View reviewed changes
packages/token-vault/README.md Outdated
1. **Client ID**: Any alphanumeric string can be used here to identity this client
2. **Client secret**: keep this blank
3. **Sign-in URLs**: This URLs should be fully qualified URLs that you want ForgeRock to redirect to provide the Authorization Code for you to collect tokens; if you're using a dynamic value like `location.href`, make sure to pay close attention to trailing slashes
4. \*\*Grant typ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a cutoff here?

@nx-cloud
Copy link

nx-cloud bot commented Jul 21, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a1a8d11. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited
Loading

Your preview environment pr-375-ryanbas21 has been deployed.

Preview environment endpoints are available at:

@cerebrl cerebrl temporarily deployed to Preview July 21, 2023 20:50 — with GitHub Actions Inactive
@ryanbas21 ryanbas21 merged commit 5161b35 into develop Jul 21, 2023
11 checks passed
@ryanbas21 ryanbas21 deleted the task_token-vault-readme branch August 2, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbas21 ryanbas21 ryanbas21 approved these changes

Assignees
No one assigned
Labels
docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cerebrl @ryanbas21