Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(token-vault): removing /sessions endpoint from interception #365

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

cerebrl
Copy link
Contributor

@cerebrl cerebrl commented Jul 12, 2023

JIRA Ticket

SDKS-2494

Description

Remove /sessions endpoint from interception as it is not associated with Access Token management and therefor should not be proxied through Token Vault.

Type of Change

Please Delete options that are not relevant

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually tested in test apps.

Definition of Done

Check all that apply

  • Acceptance criteria is met.
  • All tasks listed in the user story have been completed.
  • Coded to standards.
  • Code peer-reviewed.
  • Ensure backward compatibility (special attention).
  • API reference docs is updated.
  • Unit tests are written.
  • Integration tests are written.
  • e2e tests are written.
  • CI build passing on the feature branch.
  • Functional spec is written/updated
  • contains example code snippets.
  • Change log updated.
  • Documentation story is created and tracked.
  • UI is completed or ticket is created.
  • Demo to PO and team.
  • Tech debts and remaining tasks are tracked in separated ticket(s).

Documentation

  • Acceptance criteria met
  • Spell-check run
  • Peer reviewed
  • Proofread

@cerebrl cerebrl requested a review from ryanbas21 July 12, 2023 14:20
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

⚠️ No Changeset found

Latest commit: fef488d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cerebrl cerebrl temporarily deployed to Preview July 12, 2023 14:20 — with GitHub Actions Inactive
@github-actions github-actions bot added the test label Jul 12, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 12, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fef488d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@cerebrl cerebrl temporarily deployed to Preview July 12, 2023 22:57 — with GitHub Actions Inactive
- improve Vite configuration in Token Vault E2E app
@cerebrl cerebrl temporarily deployed to Preview July 12, 2023 23:10 — with GitHub Actions Inactive
@cerebrl cerebrl merged commit a9947b8 into develop Jul 12, 2023
11 checks passed
@ryanbas21 ryanbas21 deleted the fix_release-testing-bugs branch August 2, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants