Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-2636 Android 14 Support #316

Merged
merged 1 commit into from
Aug 29, 2023
Merged

SDKS-2636 Android 14 Support #316

merged 1 commit into from
Aug 29, 2023

Conversation

witrisna
Copy link
Contributor

SDKS-2636

Description

Android 14 Support, update compileSdk to 34 for all projects:
The following Sanity test has been performed on Android 14 Device:

  1. Centralize Login
  2. Facebook Login
  3. Google Login
  4. WebAuthn Registration and Authentication
  5. Device Binding and Verification
  6. Simple Username and Password Authentication

implementation 'androidx.annotation:annotation:1.1.0'
implementation 'androidx.security:security-crypto:1.1.0-alpha05'
implementation 'androidx.annotation:annotation:1.6.0'
implementation 'androidx.security:security-crypto:1.1.0-alpha06'
Copy link
Contributor

@jeyanthanperiyasamy jeyanthanperiyasamy Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we test the WebAuthN and DeviceBind keys survive between version upgrade (example 4.1.0 to 4.2.0) . just make sure the user does not have to reregister again in the version upgrade

Copy link
Contributor

@jeyanthanperiyasamy jeyanthanperiyasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good , just i would like to add a testing scenario for version upgrade

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@spetrov spetrov merged commit f06bd49 into develop Aug 29, 2023
@spetrov spetrov deleted the SDKS-2636 branch August 29, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants