SDKS-1408 Discrepancies between Android and iOS behavior upon registering OATH account (Issuer param) #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring OATH account (Issuer param)
spetrov
approved these changes
May 13, 2022
There was a problem hiding this comment.
Looks good to me!
I tested the fix using the steps from the problem description in SDKS-1408 and confirmed that the issue no longer occurs... i.e. when "issuer" is empty on the query parameter of the URI but available in the path, the SDK no longer throws an exception.
| @@ -93,6 +93,9 @@ private Map<String, String> map(URI uri) throws MechanismParsingException { | |||
| for (String query : queryParts) { | |||
| String[] split = split(query, "="); | |||
| if (split != null) { | |||
| if (split[0].equals(ISSUER) && split[1].isEmpty()) { | |||
There was a problem hiding this comment.
on previous line can we check this as well - if (split != null && split.length > 1) . just for safer side to avoid index out of bounds
jeyanthanperiyasamy
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-1408 Discrepancies between Android and iOS behavior upon registering OATH account (Issuer param)
Description
While registering a new mechanism, if "issuer" is empty on the query parameter of the URI, but available in the path, the SDK should not throw exception. Instead, it should use the issue in the path.
Definition of Done Checklist: