SDKS-1666, SDKS-1776 - Push Notification enhancements #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witrisna
requested changes
May 3, 2022
forgerock-authenticator/src/main/java/org/forgerock/android/auth/PushNotification.java
Outdated
Show resolved
Hide resolved
forgerock-authenticator/src/main/java/org/forgerock/android/auth/biometric/BiometricAuth.java
Show resolved
Hide resolved
forgerock-authenticator/src/main/java/org/forgerock/android/auth/biometric/BiometricAuth.java
Show resolved
Hide resolved
forgerock-authenticator/src/main/java/org/forgerock/android/auth/biometric/BiometricAuth.java
Outdated
Show resolved
Hide resolved
forgerock-authenticator/src/main/java/org/forgerock/android/auth/biometric/BiometricAuth.java
Outdated
Show resolved
Hide resolved
forgerock-authenticator/src/main/java/org/forgerock/android/auth/biometric/BiometricAuth.java
Outdated
Show resolved
Hide resolved
forgerock-authenticator/src/main/java/org/forgerock/android/auth/PushNotification.java
Show resolved
Hide resolved
forgerock-authenticator/src/main/java/org/forgerock/android/auth/DefaultStorageClient.java
Show resolved
Hide resolved
| @@ -0,0 +1,85 @@ | |||
| /* | |||
There was a problem hiding this comment.
same comment as above, we can convert this whole Fragment class to regular class if we use registerForActivityResult. but its up to you if you wanna do it now or break it . i have a story for this in the backlog. https://bugster.forgerock.org/jira/browse/SDKS-1827 .
There was a problem hiding this comment.
I would prefer leave this change to be done with the ticket in the backlog.
spetrov
requested changes
May 4, 2022
| PushNotificationActivity.this.runOnUiThread(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| Toast.makeText(thisActivity, R.string.notification_error_network_failure_message, Toast.LENGTH_LONG).show(); |
There was a problem hiding this comment.
Update the toast message to display the actual error - i.e. e.getLocalizedMessage()
| PushNotificationActivity.this.runOnUiThread(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| Toast.makeText(thisActivity, R.string.notification_error_network_failure_message, Toast.LENGTH_LONG).show(); |
There was a problem hiding this comment.
Update the toast message to display the actual error - i.e. e.getLocalizedMessage()
| @@ -64,7 +307,7 @@ public void onException(Exception e) { | |||
| PushNotificationActivity.this.runOnUiThread(new Runnable() { | |||
| @Override | |||
| public void run() { | |||
| Toast.makeText(thisActivity, R.string.notification_error_network_failure_message, Toast.LENGTH_SHORT).show(); | |||
| Toast.makeText(thisActivity, R.string.notification_error_network_failure_message, Toast.LENGTH_LONG).show(); | |||
There was a problem hiding this comment.
Update the toast message to display the actual error - i.e. e.getLocalizedMessage()
| @@ -94,15 +337,53 @@ public void onException(Exception e) { | |||
| PushNotificationActivity.this.runOnUiThread(new Runnable() { | |||
| @Override | |||
| public void run() { | |||
| Toast.makeText(thisActivity, R.string.notification_error_network_failure_message, Toast.LENGTH_SHORT).show(); | |||
| Toast.makeText(thisActivity, R.string.notification_error_network_failure_message, Toast.LENGTH_LONG).show(); | |||
There was a problem hiding this comment.
Update the toast message to display the actual error - i.e. e.getLocalizedMessage()
witrisna
reviewed
May 5, 2022
| public void onResponse(@NotNull Call call, @NotNull Response response) { | ||
| Logger.debug(TAG, "Response from server: \n" + response.toString()); | ||
| // Check if operation succeed | ||
| if(response.code() == 200) { |
There was a problem hiding this comment.
May consider to use java.net.HttpURLConnection#HTTP_OK
forgerock-authenticator/src/main/java/org/forgerock/android/auth/PushResponder.java
Show resolved
Hide resolved
forgerock-authenticator/src/main/java/org/forgerock/android/auth/PushResponder.java
Show resolved
Hide resolved
witrisna
previously approved these changes
May 6, 2022
jeyanthanperiyasamy
previously approved these changes
May 9, 2022
spetrov
previously approved these changes
May 9, 2022
rodrigoareis
dismissed stale reviews from spetrov, jeyanthanperiyasamy, and witrisna
via
ca6a252
rodrigoareis
force-pushed
the
SDKS-1666
branch
2 times, most recently
from
ca6a252 to
6d95680
Compare
SDKS-1776 Add new custom payload in the Push Notification
spetrov
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the upcoming changes on the Push Sender node (SDKS-1472). All changes are backward compatible and Unit Tests and sample app were updated to validate the changes.
JIRA Tickets included in this PR:
[SDKS-1666] Obtain timestamp from new Push Notification payload
[SDKS-1776] Add new custom payload in the Push Notification
[SDKS-1454] Sample app crash after scan push mechanism