Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-80 SSL Pinning Implementation #145

Merged
merged 1 commit into from
Mar 9, 2022
Merged

SDKS-80 SSL Pinning Implementation #145

merged 1 commit into from
Mar 9, 2022

Conversation

witrisna
Copy link
Contributor

No description provided.

Copy link
Contributor

@jeyanthanperiyasamy jeyanthanperiyasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall implementation looks good me. Left some comments to be addressed

samples/auth/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
samples/auth/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
samples/auth/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
samples/auth/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@witrisna witrisna force-pushed the SDKS-80 branch 3 times, most recently from 1715fe9 to 8b49ee3 Compare March 8, 2022 19:44
Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@spetrov spetrov merged commit e74fe7b into develop Mar 9, 2022
@spetrov spetrov deleted the SDKS-80 branch March 9, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants