-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDKS-80 SSL Pinning Implementation #145
Conversation
forgerock-auth/src/test/java/org/forgerock/android/auth/ServerConfigTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proposing a small change
https://github.com/ForgeRock/forgerock-android-sdk/pull/145/files#r816167174
forgerock-core/src/test/java/org/forgerock/android/auth/NetworkConfigTest.java
Outdated
Show resolved
Hide resolved
forgerock-core/src/test/java/org/forgerock/android/auth/NetworkConfigTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall implementation looks good me. Left some comments to be addressed
1715fe9
to
8b49ee3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
No description provided.