Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(smart-actions): add support for data-based conditions on smart action trigger, approval requirement and authorization to approve #1052

Merged
merged 1 commit into from
Dec 23, 2022
Merged

feat(smart-actions): add support for data-based conditions on smart action trigger, approval requirement and authorization to approve #1052

merged 1 commit into from
Dec 23, 2022

Conversation

ghusse
Copy link
Contributor

@ghusse ghusse commented Dec 23, 2022

…

Linked to CU-35d7gv6, CU-35d7h2b, CU-35d7h4d

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

feat(smart-actions): add support for data-based conditions on smart a…
7a90c8b 
…ction trigger, approval requirement and authorization to approve

Linked to CU-35d7gv6, CU-35d7h2b, CU-35d7h4d
@forest-bot
Copy link
Member

Task linked: CU-35d7gv6 Story #6 [forest-express] check conditions on data when triggering a smart action

@forest-bot
Copy link
Member

Task linked: CU-35d7h4d Story #18 - [forest-express] check if an action can be approved

@forest-bot
Copy link
Member

Task linked: CU-35d7h2b Story #13 - [forest-express] check if an action requires an approval

@ghusse ghusse requested a review from DayTF December 23, 2022 12:48
@DayTF DayTF assigned ghusse and unassigned DayTF Dec 23, 2022
@ghusse ghusse merged commit e3c7a1b into main Dec 23, 2022
@ghusse ghusse deleted the feat/conditional-approval branch December 23, 2022 12:58
forest-bot added a commit that referenced this pull request Dec 23, 2022
@forest-bot
chore(release): 9.1.0 [skip ci]
68db23a 
# [9.1.0](v9.0.6...v9.1.0) (2022-12-23)

### Features

* **smart-actions:** add support for data-based conditions on smart action trigger, approval requirement and authorization to approve ([#1052](#1052)) ([e3c7a1b](e3c7a1b))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ghusse added a commit that referenced this pull request Dec 23, 2022
@ghusse
Revert "feat(smart-actions): add support for data-based conditions on…
e37b8a4 
… smart action trigger, approval requirement and authorization to approve (#1052)"

This reverts commit e3c7a1b.
@ghusse ghusse mentioned this pull request Dec 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DayTF DayTF DayTF approved these changes

Assignees

@ghusse ghusse

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghusse @forest-bot @DayTF