Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Rest API versions 1.0 and 2.0 #16

Closed
ghost1face opened this issue Aug 22, 2022 · 0 comments · Fixed by #20
Closed

Remove support for Rest API versions 1.0 and 2.0 #16

ghost1face opened this issue Aug 22, 2022 · 0 comments · Fixed by #20
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ghost1face
Copy link
Member

ghost1face commented Aug 22, 2022 •
edited
Loading

This is technically breaking but shouldn't be at the same time. The NPPES team has deprecated requests for 1.0 and 2.0 so current users will have already seen failures.

We'll still look to perform this on a major version update
@ghost1face ghost1face added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 22, 2022
@ghost1face ghost1face mentioned this issue Jan 20, 2023
Open
@ghost1face ghost1face linked a pull request Jan 20, 2023 that will close this issue
Closes #8 and #16 #20
Merged
ghost1face added a commit that referenced this issue Jan 23, 2023
@ghost1face
Merge pull request #20 from tiesont/master
f0632ad 
Closes #8 and #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #8 and #16
1 participant
@ghost1face