Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Only test transcript equivalence (#5) #9

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

chrisbrickhouse
Copy link
Member

Tests of alignment and speaker assignment no longer test for equivalence of start and end times or assignment weights because different machines have slightly different results leading to failures. Instead, only the transcriptions themselves are asserted to be equivalent.

Fixes #5

Tests of alignment and speaker assignment no longer test for equivalence
of start and end times or assignment weights because different machines
have slightly different results leading to failures. Instead, only the
transcriptions themselves are asserted to be equivalent.

Fixes #5
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f89a62) 62.92% compared to head (61f5a45) 78.46%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
+ Coverage   62.92%   78.46%   +15.54%     
===========================================
  Files           2        2               
  Lines          89      130       +41     
===========================================
+ Hits           56      102       +46     
+ Misses         33       28        -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisbrickhouse chrisbrickhouse merged commit 13dc6ca into main Feb 21, 2024
5 checks passed
@chrisbrickhouse chrisbrickhouse deleted the test-fix branch April 11, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tests fail because of rounding errors
2 participants