Switch from yajl-ruby to ffi-yajl

foodcritic.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |s|
   s.add_dependency("nokogiri", ">= 1.5", "< 2.0")
   s.add_dependency("rake")
   s.add_dependency("treetop", "~> 1.4")
-  s.add_dependency("yajl-ruby", "~> 1.1")
+  s.add_dependency("ffi-yajl", "~> 2.0")
   s.add_dependency("erubis")
   s.add_dependency("rufus-lru", "~> 1.0")
 

lib/foodcritic.rb

@@ -2,7 +2,7 @@
 require "cucumber/core"
 require "treetop"
 require "ripper"
-require "yajl"
+require "ffi_yajl"
 require "erubis"
 
 require_relative "foodcritic/chef"

lib/foodcritic/api.rb

@@ -1,6 +1,5 @@
 require "nokogiri"
 require "rufus-lru"
-require "json"
 
 module FoodCritic
   # Helper methods that form part of the Rules DSL.
@@ -424,8 +423,8 @@ def json_file_to_hash(filename)
 
       file = File.read(filename)
       begin
-        JSON.parse(file)
-      rescue RuntimeError
+        FFI_Yajl::Parser.parse(file)
+      rescue FFI_Yajl::ParseError
         raise "File #{filename} does not appear to contain valid JSON"
       end
     end

lib/foodcritic/chef.rb

@@ -55,7 +55,7 @@ def load_metadata
         Linter::DEFAULT_CHEF_VERSION].map do |version|
           metadata_path(version)
         end.find { |m| File.exist?(m) }
-      @dsl_metadata ||= Yajl::Parser.parse(IO.read(metadata_path),
+      @dsl_metadata ||= FFI_Yajl::Parser.parse(IO.read(metadata_path),
                                            symbolize_keys: true)
     end
 

spec/unit/api_spec.rb

@@ -1928,7 +1928,7 @@ def template_ast(content)
     it "raises if the json is not valid" do
       expect(::File).to receive(:exist?).with("/some/path/with/a/file").and_return(true)
       allow(File).to receive(:read).with("/some/path/with/a/file").and_return("I am bogus data")
-      expect { api.json_file_to_hash("/some/path/with/a/file") }.to raise_error JSON::ParserError
+      expect { api.json_file_to_hash("/some/path/with/a/file") }.to raise_error RuntimeError
     end
   end