Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.

FC032 allow the new :before timing on resource notifications in Chef >= 12.6.0 #441

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

gnjack
Copy link
Contributor

@gnjack gnjack commented Mar 30, 2016

Since Chef 12.6.0 resource notifications now support a :before timing (in addition to :immediately and :delayed)

package "foo" do
  action :upgrade
  notifies :stop, "service[blah]", :before
end

When using :before, foodcritic rule FC032: Invalid notification timing will fail.

https://github.com/chef/chef-rfc/blob/master/rfc058-before.md
chef/chef#4062
https://tickets.opscode.com/browse/CHEF-2421

@tas50
Copy link
Contributor

tas50 commented Apr 26, 2016

@lamont-granquist Thoughts?

@lamont-granquist
Copy link
Contributor

LGTM 👍

@tas50 tas50 merged commit 31c065f into Foodcritic:master Jun 2, 2016
@dwradcliffe
Copy link
Contributor

@tas50 Can we get a new release cut?

@tas50
Copy link
Contributor

tas50 commented Jun 27, 2016

I need to add the new 12.11 metadata then I can release

@tas50 tas50 added Feature and removed Feature labels Jul 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants