Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.

Check for URLs that are helpful to the Supermarket #421

Merged
merged 10 commits into from
Jan 31, 2016

Conversation

nathenharvey
Copy link
Contributor

This PR introduces two new rules:

  • FC064 - Ensure issues_url is set in metadata
  • FC065 - Ensure source_url is set in metadata

In order to be able to share my cookbook on the Supermarket
As a developer
I want to be notified when my cookbook metadata does not specify the source_url or issues_url

I realize that not everyone who uses Foodcritic does so with the expectation that their cookbook will be shared on the Supermarket. As such, I'm proposing a new tag supermarket be added. Currently, I've tagged these two rules with both metadata and supermarket.

Implementing these two rules in Foodcritic will make the implementation of https://github.com/chef-cookbooks/cookbook-quality-metrics/ easier.

Nathen Harvey added 9 commits January 25, 2016 16:45
Ensure issues_url is set in metadata
In order to be able to share my cookbook on the Supermarket

As a developer

I want to be notified when my cookbook metadata does not specify the source_url
This is for people who want to share thier cookbooks on the Supermarket
@coderanger
Copy link
Contributor

These need to be disabled for versions of Chef which don't support the options.

@nathenharvey
Copy link
Contributor Author

thanks, @coderanger. I've updated them to only apply to chef 12.0.0 or higher.

@robbkidd
Copy link
Contributor

I propose the proposed supermarket tag be maybe collaboration. Thinking that things like issues_url facilitate collaboration no matter whether the cookbook is destined for public/private Supermarket or not.

@tas50
Copy link
Contributor

tas50 commented Jan 31, 2016

👍 Much needed.

tas50 added a commit that referenced this pull request Jan 31, 2016
Check for URLs that are helpful to the Supermarket
@tas50 tas50 merged commit adc2ca5 into Foodcritic:master Jan 31, 2016
@nathenharvey
Copy link
Contributor Author

Anyone have thoughts on @robbkidd's suggestion that the tag be collaboration instead of supermarket? While my interest lies primarily with the Supermarket for this PR, I do think collaboration better captures the nature of these rules.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants