This repository has been archived by the owner on Sep 19, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 153
Check for URLs that are helpful to the Supermarket #421
Merged
tas50
merged 10 commits into
Foodcritic:master
from
nathenharvey:nathen/urls_for_supermarket
Jan 31, 2016
Merged
Check for URLs that are helpful to the Supermarket #421
tas50
merged 10 commits into
Foodcritic:master
from
nathenharvey:nathen/urls_for_supermarket
Jan 31, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure issues_url is set in metadata
In order to be able to share my cookbook on the Supermarket As a developer I want to be notified when my cookbook metadata does not specify the source_url
This is for people who want to share thier cookbooks on the Supermarket
This was referenced Jan 26, 2016
These need to be disabled for versions of Chef which don't support the options. |
thanks, @coderanger. I've updated them to only apply to chef 12.0.0 or higher. |
I propose the proposed |
👍 Much needed. |
tas50
added a commit
that referenced
this pull request
Jan 31, 2016
Check for URLs that are helpful to the Supermarket
Anyone have thoughts on @robbkidd's suggestion that the tag be |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new rules:
In order to be able to share my cookbook on the Supermarket
As a developer
I want to be notified when my cookbook metadata does not specify the source_url or issues_url
I realize that not everyone who uses Foodcritic does so with the expectation that their cookbook will be shared on the Supermarket. As such, I'm proposing a new tag
supermarket
be added. Currently, I've tagged these two rules with bothmetadata
andsupermarket
.Implementing these two rules in Foodcritic will make the implementation of https://github.com/chef-cookbooks/cookbook-quality-metrics/ easier.