Numeric value for mode should be 5 digits (CHEF-174)

Foodcritic · Feb 21, 2012 · 5606616 · 5606616
1 parent f562b40
commit 5606616
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/features/006_check_file_mode.feature b/features/006_check_file_mode.feature
@@ -16,7 +16,7 @@ Feature: Check file mode
       | cookbook_file | 00644  |   valid             |
       | directory     |   755  | invalid             |
       | directory     |  "755" |   valid             |
-      | directory     |  0644  |   valid             |
+      | directory     |  0644  | invalid             |
       | directory     | "0644" |   valid             |
       | directory     |   400  | invalid             |
       | directory     | 00400  |   valid             |

diff --git a/lib/foodcritic/rules.rb b/lib/foodcritic/rules.rb
@@ -48,7 +48,7 @@
 rule "FC006", "Mode should be quoted or fully specified when setting file permissions" do
   tags %w{correctness files}
   recipe do |ast|
-    ast.xpath(%q{//ident[@value='mode']/parent::command/descendant::int[string-length(@value) < 4]/
+    ast.xpath(%q{//ident[@value='mode']/parent::command/descendant::int[string-length(@value) < 5]/
       ancestor::method_add_block}).map{|resource| match(resource)}
   end
 end