Subscription support, refs #31.

Foodcritic · Jun 5, 2012 · 008b1d1 · 008b1d1
1 parent 109bd03
commit 008b1d1
Show file tree

Hide file tree

Showing 2 changed files with 310 additions and 3 deletions.
diff --git a/lib/foodcritic/api.rb b/lib/foodcritic/api.rb
@@ -185,7 +185,9 @@ def match(node)
     # @return [Array] A flat array of notifications.
     def notifications(ast)
       return [] unless ast.respond_to?(:xpath)
-      ast.xpath('//command[ident/@value="notifies"]').map do |notifies|
+      ast.xpath('//command[ident/@value="notifies" or
+        ident/@value="subscribes"]').map do |notifies|
+
         params = notifies.xpath('descendant::method_add_arg[fcall/ident/
           @value="resources"]/descendant::assoc_new')
         timing = notifies.xpath('args_add_block/args_add/symbol_literal[last()]/
@@ -203,14 +205,15 @@ def notifications(ast)
         end
         {
           :type =>
-            :notifies,
+            notifies.xpath('ident/@value[1]').to_s.to_sym,
           :resource_type => resource_type,
           :resource_name => resource_name,
           :action =>
             notifies.xpath('descendant::symbol[1]/ident/@value').to_s.to_sym,
           :notification_timing =>
             timing.empty? ? :delayed : timing.first.to_s.to_sym
         }
+
       end.compact
     end