This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
Strip request origin #710
Merged
Strip request origin #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #706.
This change adds the
webRequestandwebRequestBlockingpermissions, as they are needed to modify the headers. However, according to some docs, these additional permissions should not trigger an additional permissions warning, since I believe they fall under the same category as<all_urls>.The new function
fetchAnonymousis added in this change, which strips theCookieheader and modifies theOriginheader to match the origin of the URL that is being requested.AudioUriBuilderandAudioSystemcurrently use this. TheXMLHttpRequestchanges made in #708 have been reverted tofetch.(Note that there is an extremely unlikely chance for the header modification to affect an external request, but this would require an incredibly unlikely timing exploit that also requires user input, and would ultimately not really be harmful.)