This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
Display refactor #643
Merged
Display refactor #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
toasted-nutbread
commented
Jun 29, 2020
toasted-nutbread
commented
- Static functions removed so that they can become private.
- Fields made private.
- Functions made private.
- Added a few functions to expose some functionality which used to be accomplished by directly modifying base class fields (which are now private).
- Orphan error handling moved (but needs fixed, see "Orphaned" page no longer shows when extension is reloaded/updated #642).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.