Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Set up initial manifest v3 support #605

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

toasted-nutbread
Copy link
Collaborator

@toasted-nutbread toasted-nutbread commented Jun 13, 2020

This PR is not intended to be merged, it is for testing and evaluation purposes only.

The service work can be inspected in Chrome by opening chrome://serviceworker-internals/ and inspecting the extension's service worker.

The manifest is not enabled by default, it is configured as a new build target: chrome-mv3. To update the manifest, run build --manifest chrome-mv3.

@toasted-nutbread
Copy link
Collaborator Author

Note: On the current version of Chrome Dev (87.0.4252.0), there is a bug which can prevent the browser from starting when using this branch. To reproduce:

  • Switch to this branch
  • Reload the extension
  • Close the browser
  • Switch branches to a non-manifest-v3 branch
  • Open the browser
  • Browser will crash immediately

This appears to be due to an issue with the file C:\Users\<user>\AppData\Local\Google\Chrome Dev\User Data\Default\Secure Preferences. This crash can be resolved by switching back to the manifest-v3 branch, launching the browser, changing to a non-manifest-v3 branch, and then reloading the extension.

@toasted-nutbread toasted-nutbread force-pushed the manifest-v3 branch 3 times, most recently from 3bc24e1 to 9915aa8 Compare September 20, 2020 16:17
@toasted-nutbread toasted-nutbread force-pushed the manifest-v3 branch 2 times, most recently from 444b062 to 9a540cb Compare December 18, 2020 18:51
@toasted-nutbread toasted-nutbread marked this pull request as ready for review December 18, 2020 20:51
@toasted-nutbread toasted-nutbread merged commit 51223ab into FooSoft:master Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant