This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
TextSource* API updates #2236
Merged
TextSource* API updates #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getWritingMode is also simplified
This shouldn't be necessary as the imposter is usually detached almost immediately after scanning, giving no time for the window to be resized or scrolled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
TextSourceRangeandTextSourceElementAPIs to remove anything that is unused, simplify the constructors, and fix an issue related to returning stale rects.The fixed issue would occur when scanning an element which creates an imposter (such as a textarea) and then the window is resized, which triggers a repositioning of the popup. When this repositioning occurred, it would cause the
getRect/getRectsfunction to be called, which is selecting a range which is no longer connected to the document, so the popup position would be incorrect.