Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Remove top link code #1172

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Remove top link code #1172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions ext/bg/js/settings2/settings-display-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ class SettingsDisplayController {
this._settingsController = settingsController;
this._modalController = modalController;
this._contentNode = null;
this._topLink = null;
this._menuContainer = null;
this._openPopupMenus = new Set();
this._onMoreToggleClickBind = null;
Expand All @@ -34,7 +33,6 @@ class SettingsDisplayController {

prepare() {
this._contentNode = document.querySelector('.content');
this._topLink = document.querySelector('.sidebar-top-link');
this._menuContainer = document.querySelector('#popup-menus');

const onFabButtonClick = this._onFabButtonClick.bind(this);
Expand Down Expand Up @@ -73,11 +71,6 @@ class SettingsDisplayController {
});
menuSelectorObserver.observe(document.documentElement, false);

if (this._topLink !== null) {
this._contentNode.addEventListener('scroll', this._onScroll.bind(this), {passive: true});
this._topLink.addEventListener('click', this._onTopLinkClick.bind(this), false);
}

window.addEventListener('keydown', this._onKeyDown.bind(this), false);
window.addEventListener('popstate', this._onPopState.bind(this), false);
this._updateScrollTarget();
Expand Down Expand Up @@ -109,13 +102,6 @@ class SettingsDisplayController {
this._showMenu(element, menu);
}

_onScroll(e) {
const content = e.currentTarget;
const topLink = this._topLink;
const scrollTop = content.scrollTop;
topLink.hidden = (scrollTop < 100);
}

_onFabButtonClick(e) {
const action = e.currentTarget.dataset.action;
switch (action) {
Expand Down Expand Up @@ -212,21 +198,6 @@ class SettingsDisplayController {
return false;
}

_onTopLinkClick(e) {
if (window.location.hash.length > 0) {
const {pathname, search} = window.location;
const url = `${pathname}${search}`;
history.pushState(null, '', url);
}

const content = this._contentNode;
content.scrollTop = 0;

e.preventDefault();
e.stopPropagation();
return false;
}

_onClosePopupMenu({popupMenu, onClose}) {
this._openPopupMenus.delete(popupMenu);
popupMenu.off('closed', onClose);
Expand Down Expand Up @@ -262,7 +233,6 @@ class SettingsDisplayController {
const rect1 = content.getBoundingClientRect();
const rect2 = target.getBoundingClientRect();
content.scrollTop += rect2.top - rect1.top;
this._onScroll({currentTarget: content});
}

_getMoreContainer(link) {
Expand Down