Popup proxy improvements (#764)

* Fix incorrect function invocations * Ignore setVisibleOverride when it returns null * Omit redundant async * Change default return value
FooSoft · Sep 4, 2020 · 95bfe2d · 95bfe2d
1 parent 8d53474
commit 95bfe2d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/ext/fg/js/popup-factory.js b/ext/fg/js/popup-factory.js
@@ -122,7 +122,7 @@ class PopupFactory {
             promises.push(promise);
         }
 
-        const results = await Promise.all(promises);
+        const results = (await Promise.all(promises)).filter(({token}) => token !== null);
 
         if (errors.length === 0) {
             const token = generateId(16);

diff --git a/ext/fg/js/popup-proxy.js b/ext/fg/js/popup-proxy.js
@@ -86,12 +86,12 @@ class PopupProxy extends EventDispatcher {
         return this._invokeSafe('isVisible', {id: this._id}, false);
     }
 
-    async setVisibleOverride(value, priority) {
-        return this._invokeSafe('setVisibleOverride', {id: this._id, value, priority});
+    setVisibleOverride(value, priority) {
+        return this._invokeSafe('setVisibleOverride', {id: this._id, value, priority}, null);
     }
 
-    async clearVisibleOverride(token) {
-        return this._invokeSafe('clearVisibleOverride', {id: this._id, token});
+    clearVisibleOverride(token) {
+        return this._invokeSafe('clearVisibleOverride', {id: this._id, token}, false);
     }
 
     async containsPoint(x, y) {
@@ -135,12 +135,12 @@ class PopupProxy extends EventDispatcher {
         return this._invokeSafe('updateTheme', {id: this._id});
     }
 
-    async setCustomOuterCss(css, useWebExtensionApi) {
-        return this._invokeSafe('updateTheme', {id: this._id, css, useWebExtensionApi});
+    setCustomOuterCss(css, useWebExtensionApi) {
+        return this._invokeSafe('setCustomOuterCss', {id: this._id, css, useWebExtensionApi});
     }
 
     setChildrenSupported(value) {
-        return this._invokeSafe('updateTheme', {id: this._id, value});
+        return this._invokeSafe('setChildrenSupported', {id: this._id, value});
     }
 
     getFrameRect() {