Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

add new action: answerCards #390

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

antistic
Copy link
Contributor

@antistic antistic commented Jun 14, 2023

fixes #148

might address #386

thanks for the plugin :)

@FooSoft
Copy link
Owner

FooSoft commented Jun 15, 2023

Thanks for the PR! Could you make it so that instead of having two parallel lists, the API instead takes a single list of objects that have a cardId and answer value? That will be more robust than trying to make sure that the lists are always have the same # of elements and are lining up correctly.

@antistic
Copy link
Contributor Author

antistic commented Jun 15, 2023

Sure, I initially did it that way to match with setEaseFactors and setSpecificValueOfCard but you're right a list of objects makes it easier. By objects do you means like [[123, 1], [345, 2]] or [{123: 1}], {345: 2}] or [{cardId: 123, answer: 1}, {cardId: 345, answer: 2}]?

@antistic
Copy link
Contributor Author

i went with the last one but called it "ease" since that matches the anki code, though i'm happy to change it to "button" or something else

@FooSoft
Copy link
Owner

FooSoft commented Jun 16, 2023

Looks good to me!

@FooSoft FooSoft merged commit f27e7b4 into FooSoft:master Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: answerCard action
2 participants