Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.js not working due to multipe define()-statements #89

Closed
tjveldhuizen opened this issue Feb 26, 2016 · 3 comments
Closed

r.js not working due to multipe define()-statements #89

tjveldhuizen opened this issue Feb 26, 2016 · 3 comments

Comments

@tjveldhuizen
Copy link

Similar to issue requirejs/r.js#716, when using Croppie my scripts can't get optimized due to multiple define()-statements in the code. The first one at the top, the second one is in the inclusion of Promise.

Would it be possible to find an other solution for the inclusion? Or do you have a suggestion how to optimize this? (grunt-contrib-requirejs)
@thedustinsmith
Copy link
Contributor

I've never been satisfied with our Promise polyfill, not that it doesn't function, it just looks like it was compiled from coffee script and is a tad bit ugly. I'm open to any other polyfills as long as it conforms to the standard.

@tjveldhuizen
Copy link
Author

I don't have experience with Promise polyfills... so no suggestion, unfortunately. However, I have to manually edit the files after a bower install, so I hope somebody else knows a good solution.

thedustinsmith added a commit that referenced this issue Mar 7, 2016
@thedustinsmith
replace promise polyfill #89
19ffe27
@thedustinsmith
Copy link
Contributor

This was released with 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tjveldhuizen @thedustinsmith