This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 772
variable hideBars, scroll to navigate through paragraphs and scroll to read the content are added, README.md is updated #107
Merged
hebertialmeida
merged 12 commits into
FolioReader:master
from
PanajotisMaroungas:master
Aug 12, 2016
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7cce5ff
hideBars config variable is added and FolioReaderContainer is public.…
PanajotisMaroungas 6cbb26f
'hideBars' renaming
PanajotisMaroungas a02e406
webview's frame == screen's size if AllhideBars == true
PanajotisMaroungas 966368f
minor changes, improve behaviour of the scrollview
PanajotisMaroungas 8ff6a52
update readme.md
PanajotisMaroungas ec5a2ec
update Readme md
PanajotisMaroungas b05733b
remove empty lines
PanajotisMaroungas 730da00
Merge pull request #1 from PanajotisMaroungas/readme_update
PanajotisMaroungas 2d5b67a
Update open/close book function, swipe between sections without scrol…
PanajotisMaroungas d9e0071
update read file
PanajotisMaroungas 0c66d04
Fix timer and page indicator for swipe and scroll mode
PanajotisMaroungas 5920de6
Merge branch 'upstream/master'
PanajotisMaroungas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ import UIKit | |
public enum FolioReaderScrollDirection: Int { | ||
case vertical | ||
case horizontal | ||
case sectionHorizontalContentVertical | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a really interesting addition 👍 Some points that I have noticed:
|
||
|
||
/** | ||
The current scroll direction | ||
|
@@ -21,7 +22,7 @@ public enum FolioReaderScrollDirection: Int { | |
switch self { | ||
case vertical: | ||
return .Vertical | ||
case horizontal: | ||
case horizontal, sectionHorizontalContentVertical: | ||
return .Horizontal | ||
} | ||
} | ||
|
@@ -41,7 +42,9 @@ public class FolioReaderConfig: NSObject { | |
public lazy var mediaOverlayColor: UIColor! = self.tintColor | ||
|
||
// MARK: Custom actions | ||
|
||
/// hide the navigation bar and the bottom status view | ||
public var hideBars = false | ||
|
||
/// If `canChangeScrollDirection` is `true` it will be overrided by user's option. | ||
public var scrollDirection: FolioReaderScrollDirection = .vertical | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this? This init is not public, we need to make it public to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This init still not public yet, we have to make it public on
FolioReaderContainer
.