Fix bugs that occur the most on Fabric #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0m0r3pa1n
commented
Jun 8, 2019
| @@ -19,59 +19,14 @@ public static void terminate() { | |||
| FolioDatabaseHelper.clearInstance(); | |||
| } | |||
|
|
|||
| public static boolean insert(String table, ContentValues contentValues) { | |||
There was a problem hiding this comment.
So much unused code, not sure why you need it
n0m0r3pa1n
commented
Jun 8, 2019
| @@ -244,6 +245,7 @@ class FolioActivity : AppCompatActivity(), FolioActivityCallback, MediaControlle | |||
|
|
|||
| // Need to add when vector drawables support library is used. | |||
| AppCompatDelegate.setCompatVectorFromResourcesEnabled(true) | |||
| DbAdapter.initialize(this) | |||
There was a problem hiding this comment.
Using static classes that are initialized somewhere in the lifecycle is not a good practice at all. But it will require a lot refactoring to fix everything.
n0m0r3pa1n
commented
Jun 8, 2019
| Log.v(LOG_TAG, "-> onPageFinished -> readLocator -> " + cfi!!) | ||
| mWebview!!.loadUrl(String.format(getString(R.string.callScrollToCfi), cfi)) | ||
| cfi?.let { | ||
| Log.v(LOG_TAG, "-> onPageFinished -> readLocator -> $cfi") |
There was a problem hiding this comment.
Why does the app need to crash if there are problems with the WebView?
n0m0r3pa1n
commented
Jun 8, 2019
| @@ -839,7 +841,7 @@ class FolioPageFragment : Fragment(), | |||
| if (outState != null) | |||
| outState!!.putSerializable(BUNDLE_READ_LOCATOR_CONFIG_CHANGE, lastReadLocator) | |||
| if (activity != null && !activity!!.isFinishing) | |||
| mActivityCallback!!.storeLastReadLocator(lastReadLocator) | |||
| mActivityCallback?.storeLastReadLocator(lastReadLocator) | |||
There was a problem hiding this comment.
Apparently, this is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several small bugs