Prepare for ODK 1.5 #1794
Merged
Prepare for ODK 1.5 #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libbusiness-isbn-perl package is now part of the ODK, we don't have to install it on our side.
Do not manually install the FlyBase ROBOT plugin in fbbt.Makefile. Let the ODK take care of that.
There's no need to download mirrored ontology in the test suite since we are not refreshing imports, but with IMP=false only they could still get downloaded. We need MIR=false to ensure they are not.
Commit all files re-generated or added by make update_repo.
Clare72
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
approving this, but we need to keep an eye on imported relationships to make sure we don't lose any inference in future (until INCATools/ontology-development-kit#1024 is fixed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to FlyBase/drosophila-developmental-ontology#92 for FBdv, this PR prepares the FBbt repository for the upcoming release of ODK 1.5.
In addition to removing the step that installs
libbusiness-isbn-perl(not needed anymore as the package is already included in the new ODK), this removes the custom step that installs the FlyBase ROBOT plugin, to let the ODK take care of the installation instead.