Collapse tuples of nothing
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
added a commit
to FluxML/Zygote.jl
that referenced
this pull request
Oct 24, 2023
|
Thanks! Since most of the tests are on the Zygote side, I've opened FluxML/Zygote.jl#1466 with a copy of these changes to see what CI thinks. If everything looks good, will merge this. |
|
Would be useful to add downstream tests with at least Zygote to this repo IMO. |
This was referenced Oct 24, 2023
Merged
|
Can this be merged? I encountered a similar error but not sure... |
|
See FluxML/Zygote.jl#1466 (comment). We need to do some tests on the user-facing interface in Zygote, then this can be merged. I haven't decided whether it should be a breaking change or not. |
2 tasks
ToucheSir
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Results in FluxML/Zygote.jl#1495 look good, time to merge and tag :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zygote uses the convention that tuples of
nothingare collapsed to a singlenothing. However, currently this convention is not applied to@adjoints. The PR fixes this, as suggested in FluxML/Zygote.jl#1464 (comment).