Move a bunch of no_grad to ChainRules #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
approved these changes
Sep 3, 2020
|
Lets see if Bors can retry those test. bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2020
780: Move a bunch of no_grad to ChainRules r=oxinabox a=oxinabox this is the partner to JuliaDiff/ChainRules.jl#252 It will fail til that is merged and tagged What is left is: - Types (because JuliaDiff/ChainRulesCore.jl#213) (e.g. `Colon`, `OneTo` `Channel`) - Things to which the derivative is `Zero()` not `DoesNotExist()` (e.g. `one`, `ones`, `zero`, `zeros`) - Things that felt too magic: e.g. `Base.eval` Should I bump patch version and tag a release? Co-authored-by: Lyndon White <[email protected]> Co-authored-by: Lyndon White <[email protected]>
|
Build failed: |
|
@bors r+ |
|
Should be good now that we release 0.7.17 bors r+ |
|
Build succeeded: |
|
Who's a good bot? @JuliaRegistrator register |
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
bors bot
added a commit
that referenced
this pull request
Sep 22, 2020
788: fix for rrules with kwargs and multiple zero partials r=willtebbutt a=oxinabox This fixes JuliaDiff/ChainRulesCore.jl#216 correcting a bug I introduced in #780 cc @devmotion (I have confirmed that the second test that uses the kwargs fails on Zygore#master Co-authored-by: Lyndon White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the partner to JuliaDiff/ChainRules.jl#252
It will fail til that is merged and tagged
What is left is:
Colon,OneToChannel)Zero()notDoesNotExist()(e.g.one,ones,zero,zeros)Base.evalShould I bump patch version and tag a release?