Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AMDGPU 0.9 #585

Merged
merged 1 commit into from
May 19, 2024
Merged

Add support for AMDGPU 0.9 #585

merged 1 commit into from
May 19, 2024

Conversation

pxl-th
Copy link
Member

@pxl-th pxl-th commented May 18, 2024

PR Checklist

  • Tests are added
  • Documentation, if applicable

@pxl-th pxl-th requested a review from darsnack May 19, 2024 17:58
Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we switch back to MIOpen implementations once the upstream issue is fixed? If so, can you create an issue here to track it?

@darsnack darsnack merged commit ca600b1 into master May 19, 2024
13 of 15 checks passed
@pxl-th pxl-th deleted the pxl-th/amdgpu-0.9 branch May 19, 2024 18:39
@pxl-th
Copy link
Member Author

pxl-th commented May 19, 2024

Thanks for merging! Yes, if they fix it we can add it back. Although I'd prefer to have more Julia-native kernels :)
Can we also tag a release for NNlib? I'd like to update Flux as well next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants