Replace unsafe_convert with pointer #564
Conversation
|
AMDGPU.jl compat issues on nightly are blocking us from seeing what CI thinks about this. What happens if you trim AMDGPU from Project.toml and re-run here or locally? |
|
Locally it passes, without AMDGPU, provided I relax isapprox tolerance on two batched_mul tests. |
Should no longer happen with AMDGPU 0.8.8, but I think nightly currently requires JuliaGPU/GPUCompiler.jl#546 to work. |
There was a problem hiding this comment.
CI is complaining about CUDA stuff now instead, but we should just land this and revise if necessary. The main follow-up I see is whether the accuracy changes on CI or not, because it seems to still be fine on stable Julia versions.
Side note, we should look into removing the GPU packages from the test environment when working with GHA CI. All they do right now is cause precompile latency and errors on nightly.
Closes #563, perhaps