Allow non-Int64 indices in scatter #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxl-th
changed the title
pxl-th
force-pushed
the
pxl-th/fix-typo
branch
from
3d36089 to
c19277b
Compare
pxl-th
force-pushed
the
pxl-th/fix-typo
branch
from
c19277b to
3571306
Compare
ToucheSir
reviewed
Oct 3, 2023
src/scatter.jl
Outdated
Comment on lines
132
to
134
| @inline _atomix_convert_i64(x::Int64) = x | ||
| @inline _atomix_convert_i64(x::Integer) = Int(x) | ||
| @inline _atomix_convert_i64(x) = x |
There was a problem hiding this comment.
What does the _atomix_ here mean?
There was a problem hiding this comment.
I guess I just wanted to "signal" that it is related to Atomix.IndexableRef initially. Renamed to _convert_i64.
There was a problem hiding this comment.
Also, I forgot to mention that casting to Int is only needed for atomics, where we take Atomix.pointer(::Atomix.IndexableRef) which works only with Int type.
pxl-th
force-pushed
the
pxl-th/fix-typo
branch
from
4d18497 to
103ed32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int64indices in scatter by promoting them toInt64inside the kernel.This is especially useful when performing reduction over big arrays into a few bins.
Indices can be of
Int8type, saving a lot of space.Test_Enzyme. I guess the intention was to disallow any Julia 1.10 version.PR Checklist