Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NNlib benchmarks again for production #34

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

skyleaworlder
Copy link
Collaborator

PR Checklist

  • Tests are added
  • Documentation, if applicable

Descrption

for FluxML/NNlib.jl#540, @ToucheSir & @jonas208

The NNlib benchmarks were disabled when I was developing our tool, because NNlib benchmarks really take a long time, and at that time, what I wanted is to obtain the results as quickly as possible, thus disabling them.

In this PR, I enable them again. Hopefully it works well!

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if buildkite works after merging.

@skyleaworlder skyleaworlder merged commit 19c50c2 into main Oct 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants