Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Adapt to 4, (keep existing compat) #2362

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Adapt package from 3.0 to 3.0, 4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ToucheSir ToucheSir closed this Dec 21, 2023
@ToucheSir ToucheSir reopened this Dec 21, 2023
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA failure on latest stable version looks real. Does anyone have an idea of what's going on there?

@ToucheSir
Copy link
Member

I must be missing something, because the resolver complains about Adapt incompatibilities with NNlib but NNlib does allow Adapt v3.

@christiangnrd
Copy link
Contributor

christiangnrd commented Dec 21, 2023

This should be mergeable now.

Seems like the Adapt version is pinned to 4 for these tests because otherwise the compat change PR might not actually be testing that the added compat option is compatible. I believe that registering a release for NNlib (done since v0.9.10) and OneHotArrays (done since v0.2.5), and adding Adapt version 4 to the compat entries for StructArrays (done since v0.6.17), Transducers (done since v0.4.80), and ChainRules (done since v1.60.0) will make this package resolution issue go away.

@vpuri3
Copy link
Contributor

vpuri3 commented Jan 30, 2024

@christiangnrd you need to bump metal compat Metal = "0.5, 1".

@christiangnrd
Copy link
Contributor

@christiangnrd you need to bump metal compat Metal = "0.5, 1".

I don’t have the necessary permissions to do that. I would suggest you repurpose your PR to just update Metal compat and once merged these tests should pass.

@christiangnrd
Copy link
Contributor

Close?

@ToucheSir ToucheSir closed this Jan 31, 2024
@ToucheSir ToucheSir deleted the compathelper/new_version/2023-12-19-00-16-23-153-00620777127 branch January 31, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants