-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move 5 tutorials from fluxml.github.io #2125
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1bb54d1
move 5 tutorials from fluxml.github.io
mcabbott 3601ac2
more heading links
mcabbott 55836ff
somehow fix images + links for DCGAN
mcabbott 009192b
using Flux: params
mcabbott 2aa2a7a
rm indents
mcabbott 02e9d20
ADAM
mcabbott a1ab2d0
rm using Parameters, and use distinct names
mcabbott 52b9653
local image files
mcabbott 6930d24
kill those bullet points
mcabbott 32d28a7
restore some bullets
mcabbott 15040d3
add some headings
mcabbott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding a 🚧 or some admonition in the tutorial itself so that users know this might be out of date? Or is the hope to have those sorted out before these hit a stable release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't seen one of those in a while! I don't think these are terribly out of date in fact, nothing looks like it clearly won't run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few places they needed to import
params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re updating, some of these link to the model zoo:
https://github.com/FluxML/model-zoo/blob/master/vision/mlp_mnist/mlp_mnist.jl
https://github.com/FluxML/model-zoo/blob/master/vision/conv_mnist/conv_mnist.jl
https://github.com/FluxML/model-zoo/blob/master/vision/dcgan_mnist/dcgan_mnist.jl
IDK what the plan ought to be for keeping things in sync. These all look like they qualify
Flux.params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we make them literate files, then copying over the model zoo files and deleting them from that repository would work. In the meantime, things can stay as they are.