Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make params non-differentiable (Closes #2040 & #2048) #2054

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Make params non-differentiable (Closes #2040 & #2048) #2054

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb18173
Make params non_differentiable
christiangnrd Aug 29, 2022
f5793b5
Add mention of issue #2040
christiangnrd Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/functor.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ function params(m...)
return ps
end

# Allows caching of the parameters when params is called within gradient()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a quick mention of #2040 here? Otherwise this looks good to go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed with edited comment.

@non_differentiable params(m...)

struct FluxCUDAAdaptor end
adapt_storage(to::FluxCUDAAdaptor, x) = CUDA.cu(x)
adapt_storage(to::FluxCUDAAdaptor, x::Zygote.FillArrays.AbstractFill) = CUDA.cu(collect(x))
Expand Down